Skip to content

netstorage: [traceID distribution] Change the data distribution by traceID #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 13, 2025
Merged

netstorage: [traceID distribution] Change the data distribution by traceID #65

merged 7 commits into from
Oct 13, 2025

Conversation

@jiekun
Copy link
Member

@jiekun jiekun commented Oct 6, 2025 •
edited
Loading

Describe Your Changes

For cluster mode, distribute data by trace ID instead of full random.

This feature will make the spans of the same trace go to the same vtstorage instance.

goos: darwin
goarch: arm64
pkg: github.com/VictoriaMetrics/VictoriaTraces/app/vtstorage/netinsert
cpu: Apple M1 Pro
BenchmarkGetNodeIdx
BenchmarkGetNodeIdx-8      	12863986	        93.03 ns/op	       0 B/op	       0 allocs/op
BenchmarkGetNodeIdxBak
BenchmarkGetNodeIdxBak-8   	11386562	       106.3 ns/op	       0 B/op	       0 allocs/op

A simple benchmark with 15k ingestion rate to each vtinsert:

image

Checklist

The following checks are mandatory:

@jiekun jiekun mentioned this pull request Oct 6, 2025
Closed
3 tasks
jiekun
jiekun commented Oct 7, 2025
View reviewed changes
jiekun
jiekun commented Oct 7, 2025
View reviewed changes
@jiekun jiekun merged commit 003eb7d into master Oct 13, 2025
8 checks passed
@jiekun jiekun deleted the feature/traceid-distribution branch October 13, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jiekun